Skip to content

Remove fs-extra from @tryghost/zip#427

Merged
9larsons merged 1 commit intomainfrom
remove-zip-fs-extra
Mar 2, 2026
Merged

Remove fs-extra from @tryghost/zip#427
9larsons merged 1 commit intomainfrom
remove-zip-fs-extra

Conversation

@9larsons
Copy link
Collaborator

@9larsons 9larsons commented Mar 2, 2026

Summary

  • Replace fs-extra with native node:fs in test file
  • fs.removeSync() replaced with fs.rmSync(path, {recursive: true, force: true})
  • All other functions used (existsSync, symlinkSync, writeFileSync, createWriteStream) are already native fs

Test plan

  • All 6 tests pass
  • 100% code coverage maintained

Replace fs-extra with native node:fs in tests. The only fs-extra-specific
function used was removeSync, replaced with fs.rmSync({recursive, force}).
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Warning

Rate limit exceeded

@9larsons has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a447d77 and dc1b51b.

📒 Files selected for processing (2)
  • packages/zip/package.json
  • packages/zip/test/zip.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-zip-fs-extra

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a447d77) to head (dc1b51b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #427   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         8649      8649           
  Branches      1466      1466           
=========================================
  Hits          8649      8649           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons 9larsons merged commit 69fe234 into main Mar 2, 2026
4 checks passed
@9larsons 9larsons deleted the remove-zip-fs-extra branch March 2, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants